Add TLS support #30
Open
Add TLS support #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the compatibility checks that travis reports as failing are failing on master too. I'm not sure of the cause but it appears there are problems with kafka 0.9.0. |
|
Hi there, Any chance of getting this merged? I'm currently working off a custom binary and would really like to get back to your version. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This PR adds support for broker connections using TLS. It adds optional flags for the CA cert, client cert and client key which when present will result in a TLS connection to the broker.
I haven't added to the test suite as it doesn't seem any of the areas I touched have tests. However I'd be happy to add some tests wherever you feel they are needed.
Thanks,
Toby